Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for devbox #104

Merged
merged 1 commit into from
Feb 13, 2024
Merged

add support for devbox #104

merged 1 commit into from
Feb 13, 2024

Conversation

eljohnson92
Copy link
Collaborator

@eljohnson92 eljohnson92 commented Feb 12, 2024

This PR adds support for devbox, it does not force any tool to use devbox but just supports the devbox version of the tool if it is present. if the Make target is not run within a devbox shell it reverts to the existing Makefile tool caching logic. Additionally, this PR fixes the tool Make targets so they are only run if the tool doesn't exist locally already(fixing a bug where some targets ran every time)

closes #87

@AshleyDumaine
Copy link
Contributor

Can we also update the README to call out the addition of devbox support?

@eljohnson92 eljohnson92 force-pushed the devbox_support branch 3 times, most recently from c825788 to be7c17c Compare February 13, 2024 01:29
Copy link
Collaborator

@luthermonson luthermonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@eljohnson92 eljohnson92 merged commit 8b97d86 into main Feb 13, 2024
6 checks passed
@AshleyDumaine AshleyDumaine deleted the devbox_support branch February 13, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate using devbox for tool management
3 participants